233 Remove css content callout blocks #241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And fix some missing classes and double spaces.
Contributor
|
Member
Author
|
@fschroiff, can you take a look too? If this is what you had in mind and if it passes the WCAG audit? Best preview is with the callouts on the Kitchen sink page below the code examples: https://wpaccessibility.org/pr-preview/pr-241/docs/contribute/github/content-kitchen-sink/#callouts |
Member
|
Leaving this for you to merge, @rianrietveld, if you hear from @fschroiff. |
Member
Author
|
I merged this, so Florian can include this in his WCAG-EM end review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue #233
Also: fixed missing .callout class and double spaces.
Motivation: Adding the text this way has the advantage that the text doen't look like a heading, avoiding the requirement to use a heading. I think in this case a heading is not the proper way to label the content. It's just an indication of emphasised text that belongs with the surrounding content, but needs to standout.
It also gives the flexability to write out thext than the callout's name, like for example Help wanted.
Best preview is with the callouts on the Kitchen sink page below the code examples:
https://wpaccessibility.org/pr-preview/pr-241/docs/contribute/github/content-kitchen-sink/#callouts